Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COST-4745] Update compute engine SKUs for networking #508

Merged
merged 3 commits into from
Jun 3, 2024
Merged

[COST-4745] Update compute engine SKUs for networking #508

merged 3 commits into from
Jun 3, 2024

Conversation

cgoodfred
Copy link
Contributor

The networking SKU's have changed to be consistent on wording with Data Transfer In or Data Transfer Out

Relevant GCP announcement: https://cloud.google.com/data-transfer/product-name-change-announce
SKU Verification: https://cloud.google.com/skus?hl=en&filter=Network%20VPN%20Intra%20Region%20Data%20Transfer&currency=USD

Testing:
Create a yaml that specifies a compute engine resource with any of the SKUs and see that all the values generated have the correct SKU Description.

Example generator:

  - ComputeEngineGenerator:
      start_date: last_month
      price: 20
      usage.amount_in_pricing_units: 500
      sku_id: 6B8F-E63D-832B 
      instance_type: n1-standard-4
      location.region: us-west1-a
      resource.name: projects/my_fake_project/instances/gcp_compute1
      resource.global_name: //compute.googleapis.com/projects/my_ffake_project/zones/australia-southeast1-a/instances/big_fake

@cgoodfred cgoodfred self-assigned this May 31, 2024
@codecov Codecov
Copy link

codecov bot commented May 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.7%. Comparing base (0b88a23) to head (326c08c).

Additional details and impacted files 
@@          Coverage Diff          @@
##            main    #508   +/-   ##
=====================================
  Coverage   93.7%   93.7%           
=====================================
  Files         62      62           
  Lines       4677    4677           
  Branches     658     658           
=====================================
  Hits        4383    4383           
  Misses       154     154           
  Partials     140     140

@cgoodfred cgoodfred marked this pull request as ready for review June 3, 2024 11:34
@cgoodfred cgoodfred merged commit 75f3128 into main Jun 3, 2024
4 checks passed
@cgoodfred cgoodfred deleted the COST-4745-gcp-nise-network branch June 3, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcouzens lcouzens lcouzens approved these changes

Assignees

@cgoodfred cgoodfred

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgoodfred @lcouzens